Add Sentry spans to measure sequential queue command execution time#37
Closed
elirangoshen wants to merge 1 commit into
Closed
Add Sentry spans to measure sequential queue command execution time#37elirangoshen wants to merge 1 commit into
elirangoshen wants to merge 1 commit into
Conversation
Track performance per command name in the sequential queue using Sentry spans. PusherPing is excluded to avoid heartbeat noise in telemetry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SequentialQueue.process()to measure execution time for each API command passing through the queueSequentialQueueCommandwith acommand_nameattribute for grouping by command in SentryPusherPingis excluded — it fires every 30s as a heartbeat and would spam telemetryCloses https://github.com/callstack-internal/expensify-issues/issues/2202
Test plan
SequentialQueueCommandspans appear in Sentry with correctcommand_nameattributesPusherPingdoes not appear in Sentry spansManualAppStartupspan during startup🤖 Generated with Claude Code